I believe they still need to be required? https://neo4j.com/docs/graph-data-science/current/algorithms/filtered-node-similarity/

I think they are still required https://neo4j.com/docs/graph-data-science/current/algorithms/filtered-knn/

the documentation is wrong!
if both are required, then that would mean you would need to specify both each time .e., you would not be able to add only source filter alone etc.

i think the docs are such that they reflect if you dont need to use them just go for normal similarity algo.

see also the tests in test_similarity.algos they test solo these calls etc.

Then I think we can just have two tools, node_sim and kNN, and have the optional filters?
We could also "fix" the official doc.

fine by me

but this test suggest without targetNodeFilter (which defaults to None in the code), it still works?

yep